Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 5e4aa28

Browse filesBrowse files
committed
buffer: avoid materializing ArrayBuffer for creation
Do not create an `ArrayBuffer` if the engine’s settings avoid it and we don’t need it. PR-URL: #26301 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
1 parent 9b4eec0 commit 5e4aa28
Copy full SHA for 5e4aa28

File tree

Expand file treeCollapse file tree

1 file changed

+2
-6
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+2
-6
lines changed
Open diff view settings
Collapse file

‎lib/buffer.js‎

Copy file name to clipboardExpand all lines: lib/buffer.js
+2-6Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -106,21 +106,17 @@ let poolSize, poolOffset, allocPool;
106106
const zeroFill = bindingZeroFill || [0];
107107

108108
function createUnsafeBuffer(size) {
109-
return new FastBuffer(createUnsafeArrayBuffer(size));
110-
}
111-
112-
function createUnsafeArrayBuffer(size) {
113109
zeroFill[0] = 0;
114110
try {
115-
return new ArrayBuffer(size);
111+
return new FastBuffer(size);
116112
} finally {
117113
zeroFill[0] = 1;
118114
}
119115
}
120116

121117
function createPool() {
122118
poolSize = Buffer.poolSize;
123-
allocPool = createUnsafeArrayBuffer(poolSize);
119+
allocPool = createUnsafeBuffer(poolSize).buffer;
124120
poolOffset = 0;
125121
}
126122
createPool();

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.