Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 5e1ceaa

Browse filesBrowse files
Trotttargos
authored andcommitted
build: remove redundant Makefile target
The only target that uses the `tools/doc/node_modules/js-yaml/package.json` target is `doc-only`. As a result of a recent change, it has `tools/doc/node_modules` as a prerequisite, which does the exact same npm install as `tools/doc/node_modules/js-yaml/package.json`. Remove `tools/doc/node_modules/js-yaml/package.json` as unnecessary. PR-URL: #21915 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
1 parent 3213c09 commit 5e1ceaa
Copy full SHA for 5e1ceaa

File tree

Expand file treeCollapse file tree

1 file changed

+0
-8
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+0
-8
lines changed
Open diff view settings
Collapse file

‎Makefile‎

Copy file name to clipboardExpand all lines: Makefile
-8Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -619,11 +619,6 @@ apiassets = $(subst api_assets,api/assets,$(addprefix out/,$(wildcard doc/api_as
619619
.PHONY: doc-only
620620
doc-only: tools/doc/node_modules \
621621
$(apidoc_dirs) $(apiassets) ## Builds the docs with the local or the global Node.js binary.
622-
# If it's a source tarball, assets are already in doc/api/assets,
623-
# no need to install anything, we have already copied the docs over
624-
if [ ! -d doc/api/assets ]; then \
625-
$(MAKE) tools/doc/node_modules/js-yaml/package.json; \
626-
fi;
627622
@$(MAKE) out/doc/api/all.html out/doc/api/all.json
628623

629624
.PHONY: doc
@@ -662,9 +657,6 @@ available-node = \
662657
run-npm-install = $(PWD)/$(NPM) install --production --no-package-lock
663658
run-npm-ci = $(PWD)/$(NPM) ci
664659

665-
tools/doc/node_modules/js-yaml/package.json:
666-
cd tools/doc && $(call available-node,$(run-npm-install))
667-
668660
gen-json = tools/doc/generate.js --format=json $< > $@
669661
gen-html = tools/doc/generate.js --node-version=$(FULLVERSION) --format=html \
670662
--analytics=$(DOCS_ANALYTICS) $< > $@

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.