Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 5dc293d

Browse filesBrowse files
hashseedMylesBorins
authored andcommitted
src: fix inconsistency in extern declaration
NodeCounterProvider is declared as extern but defined as EXTERN_C. This confuses clang-cl. PR-URL: #20436 Refs: #19630 Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
1 parent 21f0577 commit 5dc293d
Copy full SHA for 5dc293d

File tree

Expand file treeCollapse file tree

1 file changed

+1
-1
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+1
-1
lines changed
Open diff view settings
Collapse file

‎src/node_win32_perfctr_provider.cc‎

Copy file name to clipboardExpand all lines: src/node_win32_perfctr_provider.cc
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -119,7 +119,7 @@ PPERF_COUNTERSET_INSTANCE perfctr_instance;
119119
namespace node {
120120

121121

122-
EXTERN_C DECLSPEC_SELECTANY HANDLE NodeCounterProvider = nullptr;
122+
HANDLE NodeCounterProvider = nullptr;
123123

124124
void InitPerfCountersWin32() {
125125
ULONG status;

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.