Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 5d9f83f

Browse filesBrowse files
Trottjasnell
authored andcommitted
tools: apply linting to custom rules code
Apply our eslint rules to the code for our custom eslint rules. Eslint Inception! Maybe. I never saw that movie... PR-URL: #3195 Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Roman Reiss <me@silverwind.io>
1 parent 651a5b5 commit 5d9f83f
Copy full SHA for 5d9f83f

File tree

Expand file treeCollapse file tree

3 files changed

+6
-5
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

3 files changed

+6
-5
lines changed
Open diff view settings
Collapse file

‎Makefile‎

Copy file name to clipboardExpand all lines: Makefile
+2-1Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -505,7 +505,8 @@ bench-idle:
505505
$(NODE) benchmark/idle_clients.js &
506506

507507
jslint:
508-
$(NODE) tools/eslint/bin/eslint.js src lib test --rulesdir tools/eslint-rules --reset --quiet
508+
$(NODE) tools/eslint/bin/eslint.js src lib test tools/eslint-rules \
509+
--rulesdir tools/eslint-rules --reset --quiet
509510

510511
CPPLINT_EXCLUDE ?=
511512
CPPLINT_EXCLUDE += src/node_lttng.cc
Collapse file

‎tools/eslint-rules/require-buffer.js‎

Copy file name to clipboardExpand all lines: tools/eslint-rules/require-buffer.js
+3-3Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,9 +8,9 @@ module.exports = function(context) {
88
'Program:exit': function() {
99
context.getScope().through.forEach(function(ref) {
1010
if (ref.identifier.name === 'Buffer') {
11-
context.report(ref.identifier, msg);
11+
context.report(ref.identifier, msg);
1212
}
1313
});
1414
}
15-
}
16-
}
15+
};
16+
};
Collapse file

‎vcbuild.bat‎

Copy file name to clipboardExpand all lines: vcbuild.bat
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -246,7 +246,7 @@ goto jslint
246246
:jslint
247247
if not defined jslint goto exit
248248
echo running jslint
249-
%config%\node tools\eslint\bin\eslint.js src lib test --rulesdir tools\eslint-rules --reset --quiet
249+
%config%\node tools\eslint\bin\eslint.js src lib test tools\eslint-rules --rulesdir tools\eslint-rules --reset --quiet
250250
goto exit
251251

252252
:create-msvs-files-failed

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.