Commit 5cca693
events: avoid emit() eager deopt
This commit makes sure EventEmitter.emit() doesn't get deoptimized by
V8. The deopt happens when accessing out of bound indexes of the
`arguments` object.
This issue has been raised here: #10323 and this specific case might
become a more serious performance issue in upcoming V8 releases.
PR-URL: #10568
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>1 parent a77940c commit 5cca693Copy full SHA for 5cca693
File tree
Expand file treeCollapse file tree
1 file changed
+2
-1
lines changedOpen diff view settings
Filter options
- lib
Expand file treeCollapse file tree
1 file changed
+2
-1
lines changedOpen diff view settings
Collapse file
+2-1Lines changed: 2 additions & 1 deletion
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
148 | 148 | |
149 | 149 | |
150 | 150 | |
151 | | - |
| 151 | + |
| 152 | + |
152 | 153 | |
153 | 154 | |
154 | 155 | |
|
0 commit comments