Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 5bdfaae

Browse filesBrowse files
deokjinkimRafaelGSS
authored andcommitted
events: change status of event.returnvalue to legacy
`event.returnvalue` is described as legacy in spec. Plus, add missed '#'(private member) of defaultPrevented in implementation. Refs: https://dom.spec.whatwg.org/#interface-event Refs: https://developer.mozilla.org/en-US/docs/Web/API/Event/returnValue PR-URL: #46175 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
1 parent 4ac5c71 commit 5bdfaae
Copy full SHA for 5bdfaae

File tree

Expand file treeCollapse file tree

2 files changed

+5
-1
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

2 files changed

+5
-1
lines changed
Open diff view settings
Collapse file

‎doc/api/events.md‎

Copy file name to clipboardExpand all lines: doc/api/events.md
+4Lines changed: 4 additions & 0 deletions
  • Display the source diff
  • Display the rich diff
Original file line numberDiff line numberDiff line change
@@ -2111,8 +2111,11 @@ Sets the `defaultPrevented` property to `true` if `cancelable` is `true`.
21112111
added: v14.5.0
21122112
-->
21132113

2114+
> Stability: 3 - Legacy: Use [`event.defaultPrevented`][] instead.
2115+
21142116
* Type: {boolean} True if the event has not been canceled.
21152117

2118+
The value of `event.returnValue` is always the opposite of `event.defaultPrevented`.
21162119
This is not used in Node.js and is provided purely for completeness.
21172120

21182121
#### `event.srcElement`
@@ -2433,6 +2436,7 @@ to the `EventTarget`.
24332436
[`emitter.listenerCount()`]: #emitterlistenercounteventname
24342437
[`emitter.removeListener()`]: #emitterremovelistenereventname-listener
24352438
[`emitter.setMaxListeners(n)`]: #emittersetmaxlistenersn
2439+
[`event.defaultPrevented`]: #eventdefaultprevented
24362440
[`event.stopPropagation()`]: #eventstoppropagation
24372441
[`event.target`]: #eventtarget
24382442
[`events.defaultMaxListeners`]: #eventsdefaultmaxlisteners
Collapse file

‎lib/internal/event_target.js‎

Copy file name to clipboardExpand all lines: lib/internal/event_target.js
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -236,7 +236,7 @@ class Event {
236236
get returnValue() {
237237
if (!isEvent(this))
238238
throw new ERR_INVALID_THIS('Event');
239-
return !this.defaultPrevented;
239+
return !this.#cancelable || !this.#defaultPrevented;
240240
}
241241

242242
/**

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.