Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Commit 5b5e07a

Browse filesBrowse files
targostargos
committed
meta: update label-pr-config
- Rename "ES Modules" label to "esm" (This already happened on GitHub a while ago). - Add missing "fast-track" to deps/npm (It was lost when the pull request adding it landed). - Rename "intl" to "i18n-api" (There is no intl label). - Rename "url-whatwg" to "whatwg-url". - Rename "V8 Engine" to "v8 engine". - Rename "n-api" to "node-api". - Add "python" to .py files. - Add "gyp" to tools/gyp. - Add "icu" to tools/icu. - Add "tools" and "v8 engine" to tools/v8_gypfiles. - Add "release" to doc/changelogs. PR-URL: #38950 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>
1 parent 08b2a4a commit 5b5e07a
Copy full SHA for 5b5e07a

File tree

Expand file treeCollapse file tree

1 file changed

+25
-25
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+25
-25
lines changed
Open diff view settings
Collapse file

‎.github/label-pr-config.yml‎

Copy file name to clipboardExpand all lines: .github/label-pr-config.yml
+25-25Lines changed: 25 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -11,22 +11,22 @@ subSystemLabels:
1111
/^src\/udp_/: c++, dgram
1212
/^src\/(?:fs_|node_file|node_stat_watcher)/: c++, fs
1313
/^src\/node_http_parser/: c++, http_parser
14-
/^src\/node_i18n/: c++, intl
14+
/^src\/node_i18n/: c++, i18n-api
1515
/^src\/uv\./: c++, libuv
1616
/^src\/(?:connect(?:ion)?|pipe|tcp)_/: c++, net
1717
/^src\/node_os/: c++, os
1818
/^src\/(?:node_main|signal_)/: c++, process
1919
/^src\/timer_/: c++, timers
2020
/^src\/(?:CNNICHashWhitelist|node_root_certs|tls_)/: c++, tls
2121
/^src\/tty_/: c++, tty
22-
/^src\/node_url/: c++, url-whatwg
22+
/^src\/node_url/: c++, whatwg-url
2323
/^src\/node_util/: c++, util
24-
/^src\/(?:node_v8|v8abbr)/: c++, V8 Engine
24+
/^src\/(?:node_v8|v8abbr)/: c++, v8 engine
2525
/^src\/node_contextify/: c++, vm
2626
/^src\/.*win32.*/: c++, windows
2727
/^src\/node_zlib/: c++, zlib
2828
/^src\/tracing/: c++, tracing
29-
/^src\/node_api/: c++, n-api
29+
/^src\/node_api/: c++, node-api
3030
/^src\/node_http2/: c++, http2
3131
/^src\/node_report/: c++, report
3232
/^src\/node_wasi/: c++, wasi
@@ -35,7 +35,7 @@ subSystemLabels:
3535
/^src\/node_bob*/: c++, quic, dont-land-on-v14.x, dont-land-on-v12.x
3636

3737
# don't label python files as c++
38-
/^src\/.+\.py$/: lib / src, needs-ci
38+
/^src\/.+\.py$/: python, needs-ci
3939

4040
# properly label changes to v8 inspector integration-related files
4141
/^src\/inspector_/: c++, inspector, needs-ci
@@ -50,23 +50,24 @@ subSystemLabels:
5050
/^\w+\.md$/: doc
5151
# different variants of *Makefile and build files
5252
/^(tools\/)?(Makefile|BSDmakefile|create_android_makefiles|\.travis\.yml)$/: build, needs-ci
53-
/^tools\/(install\.py|genv8constants\.py|getnodeversion\.py|js2c\.py|utils\.py|configure\.d\/.*)$/: build, needs-ci
53+
/^tools\/(install\.py|genv8constants\.py|getnodeversion\.py|js2c\.py|utils\.py|configure\.d\/.*)$/: build, python, needs-ci
5454
/^vcbuild\.bat$/: build, windows, needs-ci
5555
/^(android-)?configure|node\.gyp|common\.gypi$/: build, needs-ci
5656
# more specific tools
57-
/^tools\/gyp/: tools, build, needs-ci, dont-land-on-v14.x, dont-land-on-v12.x
57+
/^tools\/gyp/: tools, build, gyp, needs-ci, dont-land-on-v14.x, dont-land-on-v12.x
5858
/^tools\/doc\//: tools, doc
59-
/^tools\/icu\//: tools, intl, needs-ci
59+
/^tools\/icu\//: tools, i18n-api, icu, needs-ci
6060
/^tools\/(?:osx-pkg\.pmdoc|pkgsrc)\//: tools, macos, install
6161
/^tools\/(?:(?:mac)?osx-)/: tools, macos
6262
/^tools\/test-npm/: tools, test, npm
6363
/^tools\/test/: tools, test
6464
/^tools\/(?:certdata|mkssldef|mk-ca-bundle)/: tools, openssl, tls
6565
/^tools\/msvs\//: tools, windows, install, needs-ci
6666
/^tools\/[^/]+\.bat$/: tools, windows, needs-ci
67-
/^tools\/make-v8/: tools, V8 Engine, needs-ci
68-
/^tools\/(code_cache|snapshot|v8_gypfiles)/: needs-ci,
69-
/^tools\/build-addons.js/: needs-ci,
67+
/^tools\/make-v8/: tools, v8 engine, needs-ci
68+
/^tools\/v8_gypfiles/: tools, v8 engine, needs-ci
69+
/^tools\/(code_cache|snapshot)/: needs-ci
70+
/^tools\/build-addons.js/: needs-ci
7071
# all other tool changes should be marked as such
7172
/^tools\//: tools
7273
/^\.eslint|\.remark|\.editorconfig/: tools
@@ -75,10 +76,10 @@ subSystemLabels:
7576
# libuv needs an explicit mapping, as the ordinary /deps/ mapping below would
7677
# end up as libuv changes labeled with "uv" (which is a non-existing label)
7778
/^deps\/uv\//: libuv
78-
/^deps\/v8\/tools\/gen-postmortem-metadata\.py/: V8 Engine, post-mortem
79-
/^deps\/v8\//: V8 Engine
79+
/^deps\/v8\/tools\/gen-postmortem-metadata\.py/: v8 engine, python, post-mortem
80+
/^deps\/v8\//: v8 engine
8081
/^deps\/uvwasi\//: wasi
81-
/^deps\/npm\//: npm, dont-land-on-v14.x, dont-land-on-v12.x
82+
/^deps\/npm\//: npm, fast-track, dont-land-on-v14.x, dont-land-on-v12.x
8283
/^deps\/nghttp2\/nghttp2\.gyp/: build, http2
8384
/^deps\/nghttp2\//: http2
8485
/^deps\/ngtcp2\//: quic, dont-land-on-v14.x, dont-land-on-v12.x
@@ -97,8 +98,8 @@ subSystemLabels:
9798
/^lib\/\w+\/streams$/: stream
9899
/^lib\/.*http2/: http2
99100
/^lib\/worker_threads.js$/: worker
100-
/^lib\/internal\/url\.js$/: url-whatwg
101-
/^lib\/internal\/modules\/esm/: ES Modules
101+
/^lib\/internal\/url\.js$/: whatwg-url
102+
/^lib\/internal\/modules\/esm/: esm
102103
/^lib\/internal\/quic\/*/: quic, dont-land-on-v14.x, dont-land-on-v12.x
103104

104105
# All other lib/ files map directly
@@ -115,24 +116,22 @@ exlusiveLabels:
115116
/^test\/pseudo-tty\//: test, tty
116117
/^test\/inspector\//: test, inspector
117118
/^test\/cctest\/test_inspector/: test, inspector
118-
/^test\/cctest\/test_url/: test, url-whatwg
119-
/^test\/addons-napi\//: test, n-api
119+
/^test\/cctest\/test_url/: test, whatwg-url
120+
/^test\/addons-napi\//: test, node-api
120121
/^test\/async-hooks\//: test, async_hooks
121122
/^test\/report\//: test, report
122-
/^test\/fixtures\/es-module/: test, ES Modules
123-
/^test\/es-module\//: test, ES Modules
123+
/^test\/fixtures\/es-module/: test, esm
124+
/^test\/es-module\//: test, esm
124125

125126
/^test\//: test
126127

127128
# specific map for webcrypto.md as it should be labeled 'crypto'
128129
/^doc\/api\/webcrypto.md$/: doc, crypto
129130
# specific map for modules.md as it should be labeled 'module' not 'modules'
130131
/^doc\/api\/modules.md$/: doc, module
131-
# specific map for esm.md as it should be labeled 'ES Modules' not 'esm'
132-
/^doc\/api\/esm.md$/: doc, ES Modules
133-
# n-api is treated separately since it is not a JS core module but is still
132+
# node-api is treated separately since it is not a JS core module but is still
134133
# considered a subsystem of sorts
135-
/^doc\/api\/n-api.md$/: doc, n-api
134+
/^doc\/api\/n-api.md$/: doc, node-api
136135
# quic
137136
/^doc\/api\/quic.md$/: doc, quic, dont-land-on-v14.x, dont-land-on-v12.x
138137
# add worker label to PRs that affect doc/api/worker_threads.md
@@ -141,12 +140,13 @@ exlusiveLabels:
141140
/^doc\/api\/(\w+)\.md$/: doc, $1
142141
# add deprecations label to PRs that affect doc/api/deprecations.md
143142
/^doc\/api\/deprecations.md$/: doc, deprecations
143+
/^doc\/changelogs\//: release
144144

145145
/^doc\//: doc
146146

147147
# more specific benchmarks
148148
/^benchmark\/buffers\//: benchmark, buffer
149-
/^benchmark\/(?:arrays|es)\//: benchmark, V8 Engine
149+
/^benchmark\/(?:arrays|es)\//: benchmark, v8 engine
150150
/^benchmark\/_http/: benchmark, http
151151
/^benchmark\/(?:misc|fixtures)\//: benchmark
152152
/^benchmark\/streams\//: benchmark, stream

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.