Commit 5aec513
lib: disable default memory leak warning for AbortSignal
This change sets the default `kMaxEventTargetListeners` property for
`AbortSignal` instances to 0, disabling the check per default, to
enable users to write isomorphic library code.
If desirable, the max event target listeners check can still be
enabled for individual `AbortSignal` instances by calling
`setMaxListeners` on them.
Refs: #54758
PR-URL: #55816
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>1 parent 041a490 commit 5aec513Copy full SHA for 5aec513
File tree
Expand file treeCollapse file tree
3 files changed
+29
-11
lines changedOpen diff view settings
Filter options
- doc/api
- lib/internal
- test/parallel
Expand file treeCollapse file tree
3 files changed
+29
-11
lines changedOpen diff view settings
Collapse file
+4Lines changed: 4 additions & 0 deletions
- Display the source diff
- Display the rich diff
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
1171 | 1171 | |
1172 | 1172 | |
1173 | 1173 | |
| 1174 | + |
| 1175 | + |
| 1176 | + |
| 1177 | + |
1174 | 1178 | |
1175 | 1179 | |
1176 | 1180 | |
|
Collapse file
lib/internal/abort_controller.js
Copy file name to clipboardExpand all lines: lib/internal/abort_controller.js+2Lines changed: 2 additions & 0 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
28 | 28 | |
29 | 29 | |
30 | 30 | |
| 31 | + |
31 | 32 | |
32 | 33 | |
33 | 34 | |
| ||
164 | 165 | |
165 | 166 | |
166 | 167 | |
| 168 | + |
167 | 169 | |
168 | 170 | |
169 | 171 | |
|
Collapse file
test/parallel/test-eventtarget-memoryleakwarning.js
Copy file name to clipboardExpand all lines: test/parallel/test-eventtarget-memoryleakwarning.js+23-11Lines changed: 23 additions & 11 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
12 | 12 | |
13 | 13 | |
14 | 14 | |
15 | | - |
| 15 | + |
16 | 16 | |
17 | 17 | |
18 | | - |
19 | | - |
20 | | - |
| 18 | + |
| 19 | + |
| 20 | + |
21 | 21 | |
22 | 22 | |
23 | | - |
24 | | - |
25 | | - |
| 23 | + |
| 24 | + |
| 25 | + |
26 | 26 | |
27 | | - |
28 | | - |
29 | | - |
30 | | - |
| 27 | + |
| 28 | + |
| 29 | + |
| 30 | + |
31 | 31 | |
32 | 32 | |
33 | 33 | |
| ||
65 | 65 | |
66 | 66 | |
67 | 67 | |
| 68 | + |
68 | 69 | |
| 70 | + |
| 71 | + |
| 72 | + |
69 | 73 | |
70 | 74 | |
71 | 75 | |
72 | 76 | |
73 | 77 | |
74 | 78 | |
| 79 | + |
| 80 | + |
| 81 | + |
| 82 | + |
| 83 | + |
| 84 | + |
| 85 | + |
| 86 | + |
75 | 87 | |
76 | 88 | |
77 | 89 | |
|
0 commit comments