Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Commit 5ab4471

Browse filesBrowse files
evanlucasFishrock123
evanlucas
authored and
Fishrock123
committed
build,tools: do not force codesign prefix
Allow passing the prefix in via the PKGDIR env var. This will allow us to use this same script to codesign the binary tarball. PR-URL: #14179 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
1 parent def98c6 commit 5ab4471
Copy full SHA for 5ab4471

File tree

Expand file treeCollapse file tree

2 files changed

+3
-2
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

2 files changed

+3
-2
lines changed
Open diff view settings
Collapse file

‎Makefile‎

Copy file name to clipboardExpand all lines: Makefile
+2-1Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -702,7 +702,8 @@ $(PKG): release-only
702702
--release-urlbase=$(RELEASE_URLBASE) \
703703
$(CONFIG_FLAGS) $(BUILD_RELEASE_FLAGS)
704704
$(MAKE) install V=$(V) DESTDIR=$(PKGDIR)
705-
SIGN="$(CODESIGN_CERT)" PKGDIR="$(PKGDIR)" bash tools/osx-codesign.sh
705+
SIGN="$(CODESIGN_CERT)" PKGDIR="$(PKGDIR)/usr/local" bash \
706+
tools/osx-codesign.sh
706707
cat tools/osx-pkg.pmdoc/index.xml.tmpl \
707708
| sed -E "s/\\{nodeversion\\}/$(FULLVERSION)/g" \
708709
| sed -E "s/\\{npmversion\\}/$(NPMVERSION)/g" \
Collapse file

‎tools/osx-codesign.sh‎

Copy file name to clipboardExpand all lines: tools/osx-codesign.sh
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,4 +8,4 @@ if [ "X$SIGN" == "X" ]; then
88
exit 0
99
fi
1010

11-
codesign -s "$SIGN" "$PKGDIR"/usr/local/bin/node
11+
codesign -s "$SIGN" "$PKGDIR"/bin/node

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.