Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 5a976de

Browse filesBrowse files
danbevItalo A. Casas
authored andcommitted
src: remove unnecessary req_wrap_obj
The req_wrap_obj is only used in one place which is setting up the arguments for the MakeCallback call. Removing it to simplify the code somewhat. PR-URL: #10942 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Brian White <mscdex@mscdex.net>
1 parent 0c0334f commit 5a976de
Copy full SHA for 5a976de

File tree

Expand file treeCollapse file tree

1 file changed

+1
-2
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+1
-2
lines changed
Open diff view settings
Collapse file

‎src/connection_wrap.cc‎

Copy file name to clipboardExpand all lines: src/connection_wrap.cc
+1-2Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -99,11 +99,10 @@ void ConnectionWrap<WrapType, UVType>::AfterConnect(uv_connect_t* req,
9999
writable = uv_is_writable(req->handle) != 0;
100100
}
101101

102-
Local<Object> req_wrap_obj = req_wrap->object();
103102
Local<Value> argv[5] = {
104103
Integer::New(env->isolate(), status),
105104
wrap->object(),
106-
req_wrap_obj,
105+
req_wrap->object(),
107106
Boolean::New(env->isolate(), readable),
108107
Boolean::New(env->isolate(), writable)
109108
};

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.