Commit 5983568
worker: avoid potential deadlock on NearHeapLimit
It can happen that the `NearHeapLimit` callback is called while calling
the `oninit()` function on `MessagePort` construction causing a deadlock
when the `Worker::Exit()` method is called, as the `mutex_` was already
held on the `CreateEnvMessagePort()` method. To fix it, just use the
`mutex_` to protect the `child_port_data_` variable and avoid holding it
when creating the `MessagePort`.
Also, return early from `Worker::Run()` if the worker message port
could not be created.
Fixes: #38208
PR-URL: #38403
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>1 parent 5b5e272 commit 5983568Copy full SHA for 5983568
File tree
Expand file treeCollapse file tree
3 files changed
+37
-5
lines changedOpen diff view settings
Filter options
- src
- test/parallel
Expand file treeCollapse file tree
3 files changed
+37
-5
lines changedOpen diff view settings
Collapse file
+14-4Lines changed: 14 additions & 4 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
328 | 328 | |
329 | 329 | |
330 | 330 | |
331 | | - |
| 331 | + |
| 332 | + |
| 333 | + |
| 334 | + |
332 | 335 | |
333 | 336 | |
334 | 337 | |
| ||
352 | 355 | |
353 | 356 | |
354 | 357 | |
355 | | - |
| 358 | + |
356 | 359 | |
357 | | - |
| 360 | + |
| 361 | + |
| 362 | + |
| 363 | + |
| 364 | + |
| 365 | + |
358 | 366 | |
359 | 367 | |
360 | 368 | |
361 | | - |
| 369 | + |
362 | 370 | |
363 | 371 | |
364 | 372 | |
365 | 373 | |
| 374 | + |
| 375 | + |
366 | 376 | |
367 | 377 | |
368 | 378 | |
|
Collapse file
+1-1Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
70 | 70 | |
71 | 71 | |
72 | 72 | |
73 | | - |
| 73 | + |
74 | 74 | |
75 | 75 | |
76 | 76 | |
|
Collapse file
test/parallel/test-worker-nearheaplimit-deadlock.js
Copy file name to clipboard+22Lines changed: 22 additions & 0 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
| 1 | + |
| 2 | + |
| 3 | + |
| 4 | + |
| 5 | + |
| 6 | + |
| 7 | + |
| 8 | + |
| 9 | + |
| 10 | + |
| 11 | + |
| 12 | + |
| 13 | + |
| 14 | + |
| 15 | + |
| 16 | + |
| 17 | + |
| 18 | + |
| 19 | + |
| 20 | + |
| 21 | + |
| 22 | + |
0 commit comments