Commit 5959023
http2: fix file close error condition at respondWithFd
Closing a FileHandle almost never fails, so it was hard to
notice before that `stream.emit(err)` would not emit an error
event due to the missing event name.
Destroying the stream with the error seems like the right thing
to do in that scenario.
PR-URL: #29884
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>1 parent dcdb96c commit 5959023Copy full SHA for 5959023
File tree
Expand file treeCollapse file tree
1 file changed
+1
-4
lines changedOpen diff view settings
Filter options
- lib/internal/http2
Expand file treeCollapse file tree
1 file changed
+1
-4
lines changedOpen diff view settings
Collapse file
+1-4Lines changed: 1 addition & 4 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
2174 | 2174 | |
2175 | 2175 | |
2176 | 2176 | |
2177 | | - |
2178 | | - |
2179 | | - |
2180 | 2177 | |
2181 | 2178 | |
2182 | 2179 | |
2183 | 2180 | |
2184 | | - |
| 2181 | + |
2185 | 2182 | |
2186 | 2183 | |
2187 | 2184 | |
|
0 commit comments