Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 59033f6

Browse filesBrowse files
committed
tools: fix GYP MSVS solution generator for Python 3
PR-URL: #29897 Reviewed-By: Christian Clauss <cclauss@me.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
1 parent 8da83e8 commit 59033f6
Copy full SHA for 59033f6

File tree

Expand file treeCollapse file tree

1 file changed

+3
-2
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+3
-2
lines changed
Open diff view settings
Collapse file

‎tools/gyp/pylib/gyp/MSVSNew.py‎

Copy file name to clipboardExpand all lines: tools/gyp/pylib/gyp/MSVSNew.py
+3-2Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@
77
import hashlib
88
import os
99
import random
10+
from operator import attrgetter
1011

1112
import gyp.common
1213

@@ -86,7 +87,7 @@ def __init__(self, path, name = None, entries = None,
8687
self.guid = guid
8788

8889
# Copy passed lists (or set to empty lists)
89-
self.entries = sorted(list(entries or []))
90+
self.entries = sorted(entries or [], key=attrgetter('path'))
9091
self.items = list(items or [])
9192

9293
self.entry_type_guid = ENTRY_TYPE_GUIDS['folder']
@@ -230,7 +231,7 @@ def Write(self, writer=gyp.common.WriteOnDiff):
230231
if isinstance(e, MSVSFolder):
231232
entries_to_check += e.entries
232233

233-
all_entries = sorted(all_entries)
234+
all_entries = sorted(all_entries, key=attrgetter('path'))
234235

235236
# Open file and print header
236237
f = writer(self.path)

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.