Commit 589f0d2
win: clarify Boxstarter behavior on install tools
Clarify the behavior of what Boxstarter may do when it runs on a box
to install all the necessary tools so that there are no surprises to
the end user when the script is run.
Currently there is no interface that warns the user that Boxstarter
will reboot the machine possibly multiple times depending on how many
dependencies need to be installed and doesn't mention a need to disable
UAC. For folks who see what may look like a reboot loop, we feel it is
necessary to make them aware that UAC will be disabled and they will
need to take action to re-enable UAC manually if they interfere/stop
the script from finishing.
PR-URL: #23987
Fixes: nodejs/Release#369
Reviewed-By: John-David Dalton <john.david.dalton@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>1 parent 183e3bf commit 589f0d2Copy full SHA for 589f0d2
File tree
Expand file treeCollapse file tree
1 file changed
+17
-1
lines changedOpen diff view settings
Filter options
- tools/msvs/install_tools
Expand file treeCollapse file tree
1 file changed
+17
-1
lines changedOpen diff view settings
Collapse file
tools/msvs/install_tools/install_tools.bat
Copy file name to clipboardExpand all lines: tools/msvs/install_tools/install_tools.bat+17-1Lines changed: 17 additions & 1 deletion
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
47 | 47 | |
48 | 48 | |
49 | 49 | |
50 | | - |
| 50 | + |
| 51 | + |
| 52 | + |
| 53 | + |
| 54 | + |
| 55 | + |
| 56 | + |
| 57 | + |
| 58 | + |
| 59 | + |
| 60 | + |
| 61 | + |
| 62 | + |
| 63 | + |
| 64 | + |
| 65 | + |
| 66 | + |
51 | 67 | |
52 | 68 | |
53 | 69 | |
0 commit comments