Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 585db59

Browse filesBrowse files
dYalecodebytere
authored andcommitted
test: add typeerror for vm/compileFunction params
PR-URL: #24179 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com>
1 parent 5c2c5b9 commit 585db59
Copy full SHA for 585db59

File tree

Expand file treeCollapse file tree

1 file changed

+14
-0
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+14
-0
lines changed
Open diff view settings
Collapse file

‎test/parallel/test-vm-basic.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-vm-basic.js
+14Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -207,6 +207,20 @@ const vm = require('vm');
207207
}
208208
);
209209

210+
// Testing for non Array type-based failures
211+
[Boolean(), Number(), null, Object(), Symbol(), {}].forEach(
212+
(value) => {
213+
common.expectsError(() => {
214+
vm.compileFunction('', value);
215+
}, {
216+
type: TypeError,
217+
code: 'ERR_INVALID_ARG_TYPE',
218+
message: 'The "params" argument must be of type Array. ' +
219+
`Received type ${typeof value}`
220+
});
221+
}
222+
);
223+
210224
assert.strictEqual(
211225
vm.compileFunction(
212226
'return a;',

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.