Commit 57dfd64
src: add missing override to ThreadPoolWork funcs
Currently the following warnings are displayed when compiling:
../src/node_api.cc:3380:8:
warning: 'AfterThreadPoolWork' overrides a member function but is not
marked 'override' [-Winconsistent-missing-override]
void AfterThreadPoolWork(int status) {
^
../src/node_internals.h:513:16: note: overridden virtual function is
here
virtual void AfterThreadPoolWork(int status) = 0;
^
1 warning generated.
../src/node_zlib.cc:220:8:
warning: 'DoThreadPoolWork' overrides a member function but is not
marked 'override' [-Winconsistent-missing-override]
void DoThreadPoolWork() {
^
../src/node_internals.h:512:16: note: overridden virtual function is
here
virtual void DoThreadPoolWork() = 0;
^
../src/node_zlib.cc:224:8:
warning: 'AfterThreadPoolWork' overrides a member function but is
not marked 'override' [-Winconsistent-missing-override]
void AfterThreadPoolWork(int status) {
^
../src/node_internals.h:513:16: note: overridden virtual function is
here
virtual void AfterThreadPoolWork(int status) = 0;
^
2 warnings generated.
This commit adds override to the functions.
PR-URL: #20663
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>1 parent 2347ce8 commit 57dfd64Copy full SHA for 57dfd64
File tree
Expand file treeCollapse file tree
2 files changed
+3
-3
lines changedOpen diff view settings
Filter options
- src
Expand file treeCollapse file tree
2 files changed
+3
-3
lines changedOpen diff view settings
Collapse file
+1-1Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
3377 | 3377 | |
3378 | 3378 | |
3379 | 3379 | |
3380 | | - |
| 3380 | + |
3381 | 3381 | |
3382 | 3382 | |
3383 | 3383 | |
|
Collapse file
+2-2Lines changed: 2 additions & 2 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
217 | 217 | |
218 | 218 | |
219 | 219 | |
220 | | - |
| 220 | + |
221 | 221 | |
222 | 222 | |
223 | 223 | |
224 | | - |
| 224 | + |
225 | 225 | |
226 | 226 | |
227 | 227 | |
|
0 commit comments