Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Commit 570bef1

Browse filesBrowse files
addaleaxBethGriggs
addaleax
authored and
BethGriggs
committed
Revert "src: skip test_fatal/test_threads for Debug builds"
This reverts commit 1fc4d43. PR-URL: #39954 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
1 parent 842f936 commit 570bef1
Copy full SHA for 570bef1

File tree

Expand file treeCollapse file tree

1 file changed

+0
-4
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+0
-4
lines changed
Open diff view settings
Collapse file

‎test/node-api/test_fatal/test_threads.js‎

Copy file name to clipboardExpand all lines: test/node-api/test_fatal/test_threads.js
-4Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,10 +4,6 @@ const assert = require('assert');
44
const child_process = require('child_process');
55
const test_fatal = require(`./build/${common.buildType}/test_fatal`);
66

7-
if (common.buildType === 'Debug')
8-
common.skip('as this will currently fail with a Debug check ' +
9-
'in v8::Isolate::GetCurrent()');
10-
117
// Test in a child process because the test code will trigger a fatal error
128
// that crashes the process.
139
if (process.argv[2] === 'child') {

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.