Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 56e986a

Browse filesBrowse files
committed
test: do not run release-npm test without crypto
npm requires crypto support and cannot be loaded without it. PR-URL: #30265 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
1 parent b9fd18f commit 56e986a
Copy full SHA for 56e986a

File tree

Expand file treeCollapse file tree

1 file changed

+3
-2
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+3
-2
lines changed
Open diff view settings
Collapse file

‎test/parallel/test-release-npm.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-release-npm.js
+3-2Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,12 +7,13 @@ const path = require('path');
77

88
const releaseReg = /^v\d+\.\d+\.\d+$/;
99

10-
if (!releaseReg.test(process.version)) {
10+
// Npm requires crypto support.
11+
if (!releaseReg.test(process.version) || !common.hasCrypto) {
1112
common.skip('This test is only for release builds');
1213
}
1314

1415
{
15-
// Verify that npm does not print out a warning when executed
16+
// Verify that npm does not print out a warning when executed.
1617

1718
const npmCli = path.join(__dirname, '../../deps/npm/bin/npm-cli.js');
1819
const npmExec = child_process.spawnSync(process.execPath, [npmCli]);

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.