Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 562787e

Browse filesBrowse files
BridgeARMylesBorins
authored andcommitted
assert: fix strict regression
Using `assert()` or `assert.ok()` resulted in a error since a refactoring. Refs: #17582 Backport-PR-URL: #23223 PR-URL: #17903 Refs: #17582 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
1 parent f2af930 commit 562787e
Copy full SHA for 562787e

File tree

Expand file treeCollapse file tree

2 files changed

+17
-1
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

2 files changed

+17
-1
lines changed
Open diff view settings
Collapse file

‎lib/assert.js‎

Copy file name to clipboardExpand all lines: lib/assert.js
+9-1Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -783,7 +783,15 @@ assert.ifError = function ifError(err) { if (err) throw err; };
783783

784784
// Expose a strict only variant of assert
785785
function strict(value, message) {
786-
if (!value) innerFail(value, true, message, '==', strict);
786+
if (!value) {
787+
innerFail({
788+
actual: value,
789+
expected: true,
790+
message,
791+
operator: '==',
792+
stackStartFn: strict
793+
});
794+
}
787795
}
788796
assert.strict = Object.assign(strict, assert, {
789797
equal: assert.strictEqual,
Collapse file

‎test/parallel/test-assert.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-assert.js
+8Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -711,6 +711,14 @@ common.expectsError(
711711
assert.equal(Object.keys(assert).length, Object.keys(a).length);
712712
/* eslint-enable no-restricted-properties */
713713
assert(7);
714+
common.expectsError(
715+
() => assert(),
716+
{
717+
code: 'ERR_ASSERTION',
718+
type: assert.AssertionError,
719+
message: 'undefined == true'
720+
}
721+
);
714722
}
715723

716724
common.expectsError(

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.