Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 5620b2b

Browse filesBrowse files
committed
tools: improve release proposal PR opening
- Open as draft. The releaser should review the PR and mark it as ready. - Add the "release" label. - Assign the releaser to the PR so it's clearer who's in charge and they can find it more easily. This will also notify and subscribe them to the PR. PR-URL: #56161 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
1 parent fd55d3c commit 5620b2b
Copy full SHA for 5620b2b

File tree

Expand file treeCollapse file tree

2 files changed

+5
-2
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

2 files changed

+5
-2
lines changed
Open diff view settings
Collapse file

‎.github/workflows/create-release-proposal.yml‎

Copy file name to clipboardExpand all lines: .github/workflows/create-release-proposal.yml
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@ jobs:
7878
run: |
7979
git update-index --assume-unchanged tools/actions/create-release.sh
8080
curl -fsSLo tools/actions/create-release.sh https://github.com/${GITHUB_REPOSITORY}/raw/${GITHUB_SHA}/tools/actions/create-release.sh
81-
./tools/actions/create-release.sh "${RELEASE_DATE}" "${RELEASE_LINE}"
81+
./tools/actions/create-release.sh "${RELEASE_DATE}" "${RELEASE_LINE}" "${GITHUB_ACTOR}"
8282
env:
8383
GH_TOKEN: ${{ github.token }}
8484
# We want the bot to push the push the release commit so CI runs on it.
Collapse file

‎tools/actions/create-release.sh‎

Copy file name to clipboardExpand all lines: tools/actions/create-release.sh
+4-1Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@ BOT_TOKEN=${BOT_TOKEN:-}
77

88
RELEASE_DATE=$1
99
RELEASE_LINE=$2
10+
RELEASER=$3
1011

1112
if [ -z "$RELEASE_DATE" ] || [ -z "$RELEASE_LINE" ]; then
1213
echo "Usage: $0 <RELEASE_DATE> <RELEASE_LINE>"
@@ -48,7 +49,7 @@ PR_URL="$(gh api \
4849
-H "Accept: application/vnd.github+json" \
4950
-H "X-GitHub-Api-Version: 2022-11-28" \
5051
"/repos/${GITHUB_REPOSITORY}/pulls" \
51-
-f "title=$TITLE" -f "body=$TEMP_BODY" -f "head=$HEAD_BRANCH" -f "base=v$RELEASE_LINE.x")"
52+
-f "title=$TITLE" -f "body=$TEMP_BODY" -f "head=$HEAD_BRANCH" -f "base=v$RELEASE_LINE.x" -f draft=true)"
5253

5354
# Push the release commit to the proposal branch using `BOT_TOKEN` from the env
5455
node --input-type=module - \
@@ -124,3 +125,5 @@ if (data.errors?.length) {
124125
}
125126
console.log(util.inspect(data, { depth: Infinity }));
126127
EOF
128+
129+
gh pr edit "$PR_URL" --add-label release --add-assignee "$RELEASER"

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.