Commit 551d975
http2: fix flaky test-http2-https-fallback
The test was flaky because it relied on a specific order of
asynchronous operation that were fired paralellely. This was true
on most platform and conditions, but not all the time.
See: #18986
PR-URL: #19093
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>1 parent cc90bbd commit 551d975Copy full SHA for 551d975
File tree
Expand file treeCollapse file tree
1 file changed
+29
-16
lines changedOpen diff view settings
Filter options
- test/parallel
Expand file treeCollapse file tree
1 file changed
+29
-16
lines changedOpen diff view settings
Collapse file
test/parallel/test-http2-https-fallback.js
Copy file name to clipboardExpand all lines: test/parallel/test-http2-https-fallback.js+29-16Lines changed: 29 additions & 16 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
31 | 31 | |
32 | 32 | |
33 | 33 | |
34 | | - |
| 34 | + |
35 | 35 | |
36 | 36 | |
37 | 37 | |
| ||
54 | 54 | |
55 | 55 | |
56 | 56 | |
| 57 | + |
| 58 | + |
| 59 | + |
| 60 | + |
57 | 61 | |
58 | 62 | |
59 | 63 | |
| ||
126 | 130 | |
127 | 131 | |
128 | 132 | |
129 | | - |
| 133 | + |
| 134 | + |
| 135 | + |
| 136 | + |
| 137 | + |
130 | 138 | |
131 | 139 | |
132 | | - |
133 | | - |
134 | | - |
135 | | - |
136 | | - |
137 | | - |
138 | | - |
139 | | - |
140 | | - |
141 | | - |
142 | | - |
143 | | - |
144 | | - |
145 | | - |
| 140 | + |
| 141 | + |
| 142 | + |
| 143 | + |
| 144 | + |
| 145 | + |
| 146 | + |
| 147 | + |
| 148 | + |
| 149 | + |
| 150 | + |
| 151 | + |
| 152 | + |
| 153 | + |
| 154 | + |
| 155 | + |
| 156 | + |
| 157 | + |
| 158 | + |
146 | 159 | |
147 | 160 | |
0 commit comments