Commit 54c38eb
tickprocessor: apply c++filt manually on mac
`/bin/sh -c` trick wasn't working for several reasons:
* `/bin/sh -c "..."` expects the first argument after `"..."` to be a
`$0`, not a `$1`. Previously `-n` wasn't passed to `nm` because of
this, and many symbols were ordered improperly
* `c++filt` was applied not only to the names of the functions but to
their `nm` prefixes like `t` and `a` (`t xxx` turns into
`unsigned char xxx`).
Instead of applying `c++filt` wide and using `sh -c`, execute `nm` as
requested by `deps/v8/tools/tickprocessor.js` and apply `c++filt` to all
matching entries manually.
Included test demonstrates where previous approach failed: all builtins
were merged into `v8::internal::Builtins::~Builtins`, because they were
prefixed by `t` in `nm` output.
PR-URL: #8480
Reviewed-By: Matthew Loring <mattloring@google.com>1 parent 50a4471 commit 54c38ebCopy full SHA for 54c38eb
File tree
Expand file treeCollapse file tree
3 files changed
+41
-6
lines changedOpen diff view settings
Filter options
- lib/internal
- test/parallel
Expand file treeCollapse file tree
3 files changed
+41
-6
lines changedOpen diff view settings
Collapse file
lib/internal/v8_prof_polyfill.js
Copy file name to clipboardExpand all lines: lib/internal/v8_prof_polyfill.js+32-4Lines changed: 32 additions & 4 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
38 | 38 | |
39 | 39 | |
40 | 40 | |
41 | | - |
42 | | - |
43 | | - |
44 | 41 | |
45 | | - |
| 42 | + |
| 43 | + |
| 44 | + |
| 45 | + |
| 46 | + |
46 | 47 | |
47 | 48 | |
48 | 49 | |
| ||
100 | 101 | |
101 | 102 | |
102 | 103 | |
| 104 | + |
| 105 | + |
| 106 | + |
| 107 | + |
| 108 | + |
| 109 | + |
| 110 | + |
| 111 | + |
| 112 | + |
| 113 | + |
| 114 | + |
| 115 | + |
| 116 | + |
| 117 | + |
| 118 | + |
| 119 | + |
| 120 | + |
| 121 | + |
| 122 | + |
| 123 | + |
| 124 | + |
| 125 | + |
| 126 | + |
| 127 | + |
| 128 | + |
| 129 | + |
| 130 | + |
Collapse file
lib/internal/v8_prof_processor.js
Copy file name to clipboardExpand all lines: lib/internal/v8_prof_processor.js+1-2Lines changed: 1 addition & 2 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
20 | 20 | |
21 | 21 | |
22 | 22 | |
23 | | - |
24 | | - |
| 23 | + |
25 | 24 | |
26 | 25 | |
27 | 26 | |
|
Collapse file
test/parallel/test-tick-processor.js
Copy file name to clipboardExpand all lines: test/parallel/test-tick-processor.js+8Lines changed: 8 additions & 0 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
43 | 43 | |
44 | 44 | |
45 | 45 | |
| 46 | + |
| 47 | + |
| 48 | + |
| 49 | + |
| 50 | + |
| 51 | + |
| 52 | + |
| 53 | + |
46 | 54 | |
47 | 55 | |
48 | 56 | |
|
0 commit comments