Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 5469adf

Browse filesBrowse files
aloisklinktargos
authored andcommitted
test: test pipeline end on transform streams
Add test that confirms that `stream.promises.pipeline(source, transform, dest, {end: false});` only skips ending the destination stream. `{end: false}` should still end any transform streams. PR-URL: #48970 Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
1 parent 04de576 commit 5469adf
Copy full SHA for 5469adf

File tree

Expand file treeCollapse file tree

1 file changed

+5
-1
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+5
-1
lines changed
Open diff view settings
Collapse file

‎test/parallel/test-stream-pipeline.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-stream-pipeline.js
+5-1Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1476,10 +1476,14 @@ const tsp = require('timers/promises');
14761476
});
14771477

14781478
const duplex = new PassThrough();
1479+
const transform = new PassThrough();
14791480

14801481
read.push(null);
14811482

1482-
await pipelinePromise(read, duplex, { end: false });
1483+
await pipelinePromise(read, transform, duplex, { end: false });
1484+
1485+
assert.strictEqual(transform.destroyed, true);
1486+
assert.strictEqual(transform.writableEnded, true);
14831487

14841488
assert.strictEqual(duplex.destroyed, false);
14851489
assert.strictEqual(duplex.writableEnded, false);

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.