Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 5469811

Browse filesBrowse files
cclausstargos
authored andcommitted
build: find Python syntax errors in dependencies
As discussed in #30129 (comment), when we vendor in code, we own the Syntax Errors in that code. This PR adds The `.flake8` config file at the root of this repo puts blinders on the linting of our dependencies so this test disables that file before linting. fixup: allow_failures until dependencies pass PR-URL: #30143 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
1 parent 14981f5 commit 5469811
Copy full SHA for 5469811

File tree

Expand file treeCollapse file tree

1 file changed

+12
-0
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+12
-0
lines changed
Open diff view settings
Collapse file

‎.travis.yml‎

Copy file name to clipboardExpand all lines: .travis.yml
+12Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -88,3 +88,15 @@ jobs:
8888
- if [ "${TRAVIS_PULL_REQUEST}" != "false" ]; then
8989
bash -x tools/lint-pr-commit-message.sh ${TRAVIS_PULL_REQUEST};
9090
fi
91+
92+
- name: "Find syntax errors in our Python dependencies"
93+
language: python
94+
python: 3.8
95+
install:
96+
- mv .flake8 disabled.flake8 # take the blinders off of flake8
97+
- python3.8 -m pip install --upgrade pip
98+
- python3.8 -m pip install flake8
99+
script:
100+
- flake8 . --count --select=E9,F63,F7,F82 --show-source --statistics
101+
allow_failures: # TODO (cclauss): remove this when dependencies are clean
102+
- name: "Find syntax errors in our Python dependencies"

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.