Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 52edebc

Browse filesBrowse files
edsadrMylesBorins
authored andcommitted
test: improve test-fs-empty-readStream.js
* use const instead of var * use common.mustCall to control functions execution * use assert.strictEqual instead of assert.equal * use arrow functions PR-URL: #10479 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Italo A. Casas <me@italoacasas.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Brian White <mscdex@mscdex.net>
1 parent 08e924e commit 52edebc
Copy full SHA for 52edebc

File tree

Expand file treeCollapse file tree

1 file changed

+16
-16
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+16
-16
lines changed
Open diff view settings
Collapse file
+16-16Lines changed: 16 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -1,38 +1,38 @@
11
'use strict';
2-
var common = require('../common');
3-
var assert = require('assert');
4-
var path = require('path');
5-
var fs = require('fs');
2+
const common = require('../common');
3+
const assert = require('assert');
4+
const path = require('path');
5+
const fs = require('fs');
66

7-
var emptyFile = path.join(common.fixturesDir, 'empty.txt');
7+
const emptyFile = path.join(common.fixturesDir, 'empty.txt');
88

9-
fs.open(emptyFile, 'r', function(error, fd) {
9+
fs.open(emptyFile, 'r', common.mustCall((error, fd) => {
1010
assert.ifError(error);
1111

12-
var read = fs.createReadStream(emptyFile, { 'fd': fd });
12+
const read = fs.createReadStream(emptyFile, { 'fd': fd });
1313

14-
read.once('data', function() {
14+
read.once('data', () => {
1515
throw new Error('data event should not emit');
1616
});
1717

1818
read.once('end', common.mustCall(function endEvent1() {}));
19-
});
19+
}));
2020

21-
fs.open(emptyFile, 'r', function(error, fd) {
21+
fs.open(emptyFile, 'r', common.mustCall((error, fd) => {
2222
assert.ifError(error);
2323

24-
var read = fs.createReadStream(emptyFile, { 'fd': fd });
24+
const read = fs.createReadStream(emptyFile, { 'fd': fd });
2525
read.pause();
2626

27-
read.once('data', function() {
27+
read.once('data', () => {
2828
throw new Error('data event should not emit');
2929
});
3030

3131
read.once('end', function endEvent2() {
3232
throw new Error('end event should not emit');
3333
});
3434

35-
setTimeout(function() {
36-
assert.equal(read.isPaused(), true);
37-
}, common.platformTimeout(50));
38-
});
35+
setTimeout(common.mustCall(() => {
36+
assert.strictEqual(read.isPaused(), true);
37+
}), common.platformTimeout(50));
38+
}));

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.