Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 528edb2

Browse filesBrowse files
addaleaxgibfahn
authored andcommitted
build: ignore empty folders in test-addons-napi
The same as #16031 except for N-API addons. PR-URL: #16380 Fixes: #13521 Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
1 parent a628455 commit 528edb2
Copy full SHA for 528edb2

File tree

Expand file treeCollapse file tree

1 file changed

+6
-1
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+6
-1
lines changed
Open diff view settings
Collapse file

‎Makefile‎

Copy file name to clipboardExpand all lines: Makefile
+6-1Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -299,7 +299,8 @@ test/addons/.buildstamp: config.gypi \
299299
test/addons/.docbuildstamp
300300
# Cannot use $(wildcard test/addons/*/) here, it's evaluated before
301301
# embedded addons have been generated from the documentation.
302-
# Ignore folders without binding.gyp (#14843)
302+
# Ignore folders without binding.gyp
303+
# (https://github.com/nodejs/node/issues/14843)
303304
@for dirname in test/addons/*/; do \
304305
if [ ! -f "$$PWD/$${dirname}binding.gyp" ]; then \
305306
continue; fi ; \
@@ -337,7 +338,11 @@ test/addons-napi/.buildstamp: config.gypi \
337338
src/node_api.h src/node_api_types.h
338339
# Cannot use $(wildcard test/addons-napi/*/) here, it's evaluated before
339340
# embedded addons have been generated from the documentation.
341+
# Ignore folders without binding.gyp
342+
# (https://github.com/nodejs/node/issues/14843)
340343
@for dirname in test/addons-napi/*/; do \
344+
if [ ! -f "$$PWD/$${dirname}binding.gyp" ]; then \
345+
continue; fi ; \
341346
printf "\nBuilding addon $$PWD/$$dirname\n" ; \
342347
env MAKEFLAGS="-j1" $(NODE) deps/npm/node_modules/node-gyp/bin/node-gyp \
343348
--loglevel=$(LOGLEVEL) rebuild \

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.