Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 5209ff9

Browse filesBrowse files
danbevtargos
authored andcommitted
src: remove unused fields msg_ and env_
Currently the following compiler warnings are generated: ../src/node_messaging.cc:74:16: warning: private field 'env_' is not used [-Wunused-private-field] Environment* env_; ^ ../src/node_messaging.cc:75:12: warning: private field 'msg_' is not used [-Wunused-private-field] Message* msg_; ^ 2 warnings generated. This commit removes these unused private members. PR-URL: #20876 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Shingo Inoue <leko.noor@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: John-David Dalton <john.david.dalton@gmail.com> Reviewed-By: Gus Caplan <me@gus.host>
1 parent d1f372f commit 5209ff9
Copy full SHA for 5209ff9

File tree

Expand file treeCollapse file tree

1 file changed

+1
-5
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+1
-5
lines changed
Open diff view settings
Collapse file

‎src/node_messaging.cc‎

Copy file name to clipboardExpand all lines: src/node_messaging.cc
+1-5Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -47,9 +47,7 @@ class DeserializerDelegate : public ValueDeserializer::Delegate {
4747
const std::vector<MessagePort*>& message_ports,
4848
const std::vector<Local<SharedArrayBuffer>>&
4949
shared_array_buffers)
50-
: env_(env),
51-
msg_(m),
52-
message_ports_(message_ports),
50+
: message_ports_(message_ports),
5351
shared_array_buffers_(shared_array_buffers) {}
5452

5553
MaybeLocal<Object> ReadHostObject(Isolate* isolate) override {
@@ -71,8 +69,6 @@ class DeserializerDelegate : public ValueDeserializer::Delegate {
7169
ValueDeserializer* deserializer = nullptr;
7270

7371
private:
74-
Environment* env_;
75-
Message* msg_;
7672
const std::vector<MessagePort*>& message_ports_;
7773
const std::vector<Local<SharedArrayBuffer>>& shared_array_buffers_;
7874
};

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.