Commit 514e516
test: deflake test-diagnostics-channel-net
This test uses the deprecated methods in `diagnostic_channel` (see the
reference), which are deprecated because the channels can be GC'd while
in use, leading to lost messages.
Change to use the non-deprecated APIs, which should work. I wasn't able
to reproduce this locally; I assume it's memory dependent.
Refs: #42714
Fixes: #44143
PR-URL: #44144
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>1 parent 1a44fbc commit 514e516Copy full SHA for 514e516
File tree
Expand file treeCollapse file tree
1 file changed
+2
-5
lines changedOpen diff view settings
Filter options
- test/parallel
Expand file treeCollapse file tree
1 file changed
+2
-5
lines changedOpen diff view settings
Collapse file
test/parallel/test-diagnostics-channel-net.js
Copy file name to clipboardExpand all lines: test/parallel/test-diagnostics-channel-net.js+2-5Lines changed: 2 additions & 5 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
4 | 4 | |
5 | 5 | |
6 | 6 | |
7 | | - |
8 | | - |
9 | | - |
10 | 7 | |
11 | 8 | |
12 | | - |
| 9 | + |
13 | 10 | |
14 | 11 | |
15 | 12 | |
16 | | - |
| 13 | + |
17 | 14 | |
18 | 15 | |
19 | 16 | |
|
0 commit comments