Commit 513ab0e
worker: fix --abort-on-uncaught-exception handling
The `set_abort_on_uncaught_exception(false)` line was supposed to
prevent aborting when running Workers in
`--abort-on-uncaught-exception` mode, but it was incorrectly set
and not checked properly in the should-abort callback.
PR-URL: #34724
Backport-PR-URL: #34815
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Mary Marchini <oss@mmarchini.me>1 parent 03d6013 commit 513ab0eCopy full SHA for 513ab0e
File tree
Expand file treeCollapse file tree
3 files changed
+17
-3
lines changedOpen diff view settings
Filter options
- src
- api
- test/parallel
Expand file treeCollapse file tree
3 files changed
+17
-3
lines changedOpen diff view settings
Collapse file
+1-3Lines changed: 1 addition & 3 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
42 | 42 | |
43 | 43 | |
44 | 44 | |
| 45 | + |
45 | 46 | |
46 | 47 | |
47 | 48 | |
| ||
355 | 356 | |
356 | 357 | |
357 | 358 | |
358 | | - |
359 | | - |
360 | | - |
361 | 359 | |
362 | 360 | |
363 | 361 | |
|
Collapse file
+4Lines changed: 4 additions & 0 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
348 | 348 | |
349 | 349 | |
350 | 350 | |
| 351 | + |
| 352 | + |
| 353 | + |
| 354 | + |
351 | 355 | |
352 | 356 | |
353 | 357 | |
|
Collapse file
test/parallel/test-worker-abort-on-uncaught-exception.js
Copy file name to clipboard+12Lines changed: 12 additions & 0 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
| 1 | + |
| 2 | + |
| 3 | + |
| 4 | + |
| 5 | + |
| 6 | + |
| 7 | + |
| 8 | + |
| 9 | + |
| 10 | + |
| 11 | + |
| 12 | + |
0 commit comments