Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 5129b7c

Browse filesBrowse files
Trotttargos
authored andcommitted
tools: fix small not-quite-a-bug in find-inactive-tsc.mjs
The current code attempts to count votes from people who were not members at the start of the 3 month period, resulting in `NaN` being tallied for their votes. PR-URL: #41469 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Tierney Cyren <hello@bnb.im>
1 parent 7ac126b commit 5129b7c
Copy full SHA for 5129b7c

File tree

Expand file treeCollapse file tree

1 file changed

+3
-1
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+3
-1
lines changed
Open diff view settings
Collapse file

‎tools/find-inactive-tsc.mjs‎

Copy file name to clipboardExpand all lines: tools/find-inactive-tsc.mjs
+3-1Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -118,7 +118,9 @@ async function getVotingRecords(tscMembers, votes) {
118118
await fs.promises.readFile(path.join('.tmp', vote), 'utf8')
119119
);
120120
for (const member in voteData.votes) {
121-
votingRecords[member]++;
121+
if (tscMembers.includes(member)) {
122+
votingRecords[member]++;
123+
}
122124
}
123125
}
124126
return votingRecords;

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.