Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 4f8bf1b

Browse filesBrowse files
jalafelMyles Borins
authored andcommitted
doc: explains why Reviewed-By is added in PRs
Adds verbose reasons to the documentation on why the Reviewed-By metadata on a pull request is important. This was loosely mentioned as an issue in the referenced issue below, and answered by @addaleax. Ref: #8893 PR-URL: #9044 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
1 parent af645a0 commit 4f8bf1b
Copy full SHA for 4f8bf1b

File tree

Expand file treeCollapse file tree

1 file changed

+2
-0
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+2
-0
lines changed
Open diff view settings
Collapse file

‎COLLABORATOR_GUIDE.md‎

Copy file name to clipboardExpand all lines: COLLABORATOR_GUIDE.md
+2Lines changed: 2 additions & 0 deletions
  • Display the source diff
  • Display the rich diff
Original file line numberDiff line numberDiff line change
@@ -101,6 +101,8 @@ information regarding the change process:
101101

102102
- A `Reviewed-By: Name <email>` line for yourself and any
103103
other Collaborators who have reviewed the change.
104+
- Useful for @mentions / contact list if something goes wrong in the PR.
105+
- Protects against the assumption that GitHub will be around forever.
104106
- A `PR-URL:` line that references the *full* GitHub URL of the original
105107
pull request being merged so it's easy to trace a commit back to the
106108
conversation that led up to that change.

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.