Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 4f50d3f

Browse filesBrowse files
committed
process: make process.release.name "node"
This commit sets the value of process.release.name to "node". Fixes: #2361 PR-URL: #2367 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rod Vagg <rod@vagg.org>
1 parent 45a2046 commit 4f50d3f
Copy full SHA for 4f50d3f

File tree

Expand file treeCollapse file tree

2 files changed

+4
-3
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

2 files changed

+4
-3
lines changed
Open diff view settings
Collapse file

‎doc/api/process.markdown‎

Copy file name to clipboardExpand all lines: doc/api/process.markdown
+3-2Lines changed: 3 additions & 2 deletions
  • Display the source diff
  • Display the rich diff
Original file line numberDiff line numberDiff line change
@@ -679,7 +679,8 @@ for the source tarball and headers-only tarball.
679679

680680
`process.release` contains the following properties:
681681

682-
* `name`: a string with a value that will always be `"node.js"` for Node.js.
682+
* `name`: a string with a value that will always be `"node"` for Node.js. For
683+
legacy io.js releases, this will be `"io.js"`.
683684
* `sourceUrl`: a complete URL pointing to a _.tar.gz_ file containing the
684685
source of the current release.
685686
* `headersUrl`: a complete URL pointing to a _.tar.gz_ file containing only
@@ -693,7 +694,7 @@ for the source tarball and headers-only tarball.
693694

694695
e.g.
695696

696-
{ name: 'node.js',
697+
{ name: 'node',
697698
sourceUrl: 'https://nodejs.org/download/release/v4.0.0/node-v4.0.0.tar.gz',
698699
headersUrl: 'https://nodejs.org/download/release/v4.0.0/node-v4.0.0-headers.tar.gz',
699700
libUrl: 'https://nodejs.org/download/release/v4.0.0/win-x64/node.lib' }
Collapse file

‎src/node.cc‎

Copy file name to clipboardExpand all lines: src/node.cc
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2768,7 +2768,7 @@ void SetupProcessObject(Environment* env,
27682768
// process.release
27692769
Local<Object> release = Object::New(env->isolate());
27702770
READONLY_PROPERTY(process, "release", release);
2771-
READONLY_PROPERTY(release, "name", OneByteString(env->isolate(), "node.js"));
2771+
READONLY_PROPERTY(release, "name", OneByteString(env->isolate(), "node"));
27722772

27732773
// if this is a release build and no explicit base has been set
27742774
// substitute the standard release download URL

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.