Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 4f00562

Browse filesBrowse files
kenny-ytargos
authored andcommitted
build: add new benchmark targets
Adding new build targets: 'bench-addons' & 'bench-addons-clean'. With these two, it will be easier to manage the dependencies among targets and easier to build/clean the addons which are being used in benchmarking. PR-URL: #20905 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
1 parent 4c5fc5c commit 4f00562
Copy full SHA for 4f00562

File tree

Expand file treeCollapse file tree

1 file changed

+13
-2
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+13
-2
lines changed
Open diff view settings
Collapse file

‎Makefile‎

Copy file name to clipboardExpand all lines: Makefile
+13-2Lines changed: 13 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -141,6 +141,7 @@ clean: ## Remove build artifacts.
141141
$(RM) -r test/tmp*
142142
$(RM) -r test/.tmp*
143143
$(MAKE) test-addons-clean
144+
$(MAKE) bench-addons-clean
144145

145146
.PHONY: distclean
146147
distclean:
@@ -1054,13 +1055,23 @@ ifeq ($(XZ), 0)
10541055
endif
10551056

10561057
.PHONY: bench-all
1057-
bench-all:
1058+
bench-all: bench-addons-build
10581059
@echo "Please use benchmark/run.js or benchmark/compare.js to run the benchmarks."
10591060

10601061
.PHONY: bench
1061-
bench:
1062+
bench: bench-addons-build
10621063
@echo "Please use benchmark/run.js or benchmark/compare.js to run the benchmarks."
10631064

1065+
# Build required addons for benchmark before running it.
1066+
.PHONY: bench-addons-build
1067+
bench-addons-build: benchmark/napi/function_call/build/Release/binding.node \
1068+
benchmark/napi/function_args/build/Release/binding.node
1069+
1070+
.PHONY: bench-addons-clean
1071+
bench-addons-clean:
1072+
$(RM) -r benchmark/napi/function_call/build
1073+
$(RM) -r benchmark/napi/function_args/build
1074+
10641075
.PHONY: lint-md-clean
10651076
lint-md-clean:
10661077
$(RM) -r tools/remark-cli/node_modules

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.