Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 4e33532

Browse filesBrowse files
RaisinTendanielleadams
authored andcommitted
src: use HandleScope in StreamReq::Done()
Fixes: #38707 PR-URL: #38720 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
1 parent 2054efa commit 4e33532
Copy full SHA for 4e33532

File tree

Expand file treeCollapse file tree

2 files changed

+14
-0
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

2 files changed

+14
-0
lines changed
Open diff view settings
Collapse file

‎src/stream_base-inl.h‎

Copy file name to clipboardExpand all lines: src/stream_base-inl.h
+1Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -279,6 +279,7 @@ void StreamReq::Done(int status, const char* error_str) {
279279
AsyncWrap* async_wrap = GetAsyncWrap();
280280
Environment* env = async_wrap->env();
281281
if (error_str != nullptr) {
282+
v8::HandleScope handle_scope(env->isolate());
282283
async_wrap->object()->Set(env->context(),
283284
env->error_string(),
284285
OneByteString(env->isolate(), error_str))
Collapse file
+13Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,13 @@
1+
'use strict';
2+
3+
const common = require('../common');
4+
if (!common.hasCrypto)
5+
common.skip('missing crypto');
6+
7+
const https = require('https');
8+
9+
const request = https.get('https://example.com');
10+
11+
request.on('socket', (socket) => {
12+
socket.unref();
13+
});

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.