Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 4e18651

Browse filesBrowse files
okmttdhrtargos
authored andcommitted
lib: rename internal module declaration as internal bindings
This is a follow-up to #45551 . Renaming NODE_MODULE_CONTEXT_AWARE_INTERNAL to NODE_BINDING_CONTEXT_AWARE_INTERNAL. As these bindings are already loaded with the function internalBinding in the JS land, the term "internal binding" can be straightforward to be adopted. PR-URL: #46663 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
1 parent 2fece54 commit 4e18651
Copy full SHA for 4e18651

File tree

Expand file treeCollapse file tree

1 file changed

+1
-1
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+1
-1
lines changed
Open diff view settings
Collapse file

‎lib/internal/bootstrap/loaders.js‎

Copy file name to clipboardExpand all lines: lib/internal/bootstrap/loaders.js
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
// NM_F_LINKED.
2121
// - internalBinding(): the private internal C++ binding loader, inaccessible
2222
// from user land unless through `require('internal/test/binding')`.
23-
// These C++ bindings are created using NODE_MODULE_CONTEXT_AWARE_INTERNAL()
23+
// These C++ bindings are created using NODE_BINDING_CONTEXT_AWARE_INTERNAL()
2424
// and have their nm_flags set to NM_F_INTERNAL.
2525
//
2626
// Internal JavaScript module loader:

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.