Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Commit 4e14ed8

Browse filesBrowse files
daeyeonRafaelGSS
daeyeon
authored and
RafaelGSS
committed
src: remove unused contextify_global_private_symbol
`contextify_global_private_symbol` is no longer used. It was used to hold a new context's global object, but the approach has been changed to hold a ContextifyContext wrapper using `contextify_context_private_symbol`. Signed-off-by: Daeyeon Jeong <daeyeon.dev@gmail.com> PR-URL: #45128 Refs: #44796 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
1 parent a2620ac commit 4e14ed8
Copy full SHA for 4e14ed8

File tree

Expand file treeCollapse file tree

2 files changed

+6
-8
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

2 files changed

+6
-8
lines changed
Open diff view settings
Collapse file

‎src/env_properties.h‎

Copy file name to clipboardExpand all lines: src/env_properties.h
-1Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@
2020
#define PER_ISOLATE_PRIVATE_SYMBOL_PROPERTIES(V) \
2121
V(arrow_message_private_symbol, "node:arrowMessage") \
2222
V(contextify_context_private_symbol, "node:contextify:context") \
23-
V(contextify_global_private_symbol, "node:contextify:global") \
2423
V(decorated_private_symbol, "node:decorated") \
2524
V(napi_type_tag, "node:napi:type_tag") \
2625
V(napi_wrapper, "node:napi:wrapper") \
Collapse file

‎typings/internalBinding/util.d.ts‎

Copy file name to clipboardExpand all lines: typings/internalBinding/util.d.ts
+6-7Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -8,15 +8,14 @@ declare namespace InternalUtilBinding {
88
}
99

1010
declare function InternalBinding(binding: 'util'): {
11-
// PER_ISOLATE_PRIVATE_SYMBOL_PROPERTIES, defined in src/env.h
11+
// PER_ISOLATE_PRIVATE_SYMBOL_PROPERTIES, defined in src/env_properties.h
1212
arrow_message_private_symbol: 1;
1313
contextify_context_private_symbol: 2;
14-
contextify_global_private_symbol: 3;
15-
decorated_private_symbol: 4;
16-
napi_type_tag: 5;
17-
napi_wrapper: 6;
18-
untransferable_object_private_symbol: 7;
19-
exiting_aliased_Uint32Array: 8;
14+
decorated_private_symbol: 3;
15+
napi_type_tag: 4;
16+
napi_wrapper: 5;
17+
untransferable_object_private_symbol: 6;
18+
exiting_aliased_Uint32Array: 7;
2019

2120
kPending: 0;
2221
kFulfilled: 1;

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.