Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 4dffd04

Browse filesBrowse files
committed
cli: --perf-prof only works on Linux
PR-URL: #31892 Reviewed-By: Matheus Marchini <mat@mmarchini.me> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
1 parent 4fe9e04 commit 4dffd04
Copy full SHA for 4dffd04

File tree

Expand file treeCollapse file tree

2 files changed

+8
-6
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

2 files changed

+8
-6
lines changed
Open diff view settings
Collapse file

‎doc/api/cli.md‎

Copy file name to clipboardExpand all lines: doc/api/cli.md
+3Lines changed: 3 additions & 0 deletions
  • Display the source diff
  • Display the rich diff
Original file line numberDiff line numberDiff line change
@@ -1164,6 +1164,9 @@ V8 options that are allowed are:
11641164
* `--stack-trace-limit`
11651165
<!-- node-options-v8 end -->
11661166

1167+
`--perf-basic-prof-only-functions`, `--perf-basic-prof`,
1168+
`--perf-prof-unwinding-info`, and `--perf-prof` are only available on Linux.
1169+
11671170
### `NODE_PATH=path[:…]`
11681171
<!-- YAML
11691172
added: v0.1.32
Collapse file

‎test/parallel/test-cli-node-options.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-cli-node-options.js
+5-6Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -48,15 +48,14 @@ expectNoWorker('--trace-event-file-pattern {pid}-${rotation}.trace_events ' +
4848
'--trace-event-categories node.async_hooks', 'B\n');
4949
expect('--unhandled-rejections=none', 'B\n');
5050

51-
if (!common.isWindows) {
51+
if (common.isLinux) {
5252
expect('--perf-basic-prof', 'B\n');
5353
expect('--perf-basic-prof-only-functions', 'B\n');
54-
}
5554

56-
if (common.isLinux && ['arm', 'x64'].includes(process.arch)) {
57-
// PerfJitLogger is only implemented in Linux.
58-
expect('--perf-prof', 'B\n');
59-
expect('--perf-prof-unwinding-info', 'B\n');
55+
if (['arm', 'x64'].includes(process.arch)) {
56+
expect('--perf-prof', 'B\n');
57+
expect('--perf-prof-unwinding-info', 'B\n');
58+
}
6059
}
6160

6261
if (common.hasCrypto) {

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.