Commit 4d916da
test: fail when child dies in fork-net
Previously when the child dies with errors in this test, the parent
will just hang and timeout, the errors in the child would be
swallowed. This makes it fail so at least there is more information
about why this test fails.
Also removes the unnecessary child.kill() call.
PR-URL: #11684
Ref: #11667
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>1 parent 1158f44 commit 4d916daCopy full SHA for 4d916da
File tree
Expand file treeCollapse file tree
1 file changed
+5
-5
lines changedOpen diff view settings
Filter options
- test/parallel
Expand file treeCollapse file tree
1 file changed
+5
-5
lines changedOpen diff view settings
Collapse file
test/parallel/test-child-process-fork-net.js
Copy file name to clipboardExpand all lines: test/parallel/test-child-process-fork-net.js+5-5Lines changed: 5 additions & 5 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
1 | 1 | |
2 | | - |
| 2 | + |
3 | 3 | |
4 | 4 | |
5 | 5 | |
| ||
60 | 60 | |
61 | 61 | |
62 | 62 | |
63 | | - |
64 | | - |
65 | | - |
| 63 | + |
| 64 | + |
| 65 | + |
| 66 | + |
66 | 67 | |
67 | 68 | |
68 | 69 | |
| ||
171 | 172 | |
172 | 173 | |
173 | 174 | |
174 | | - |
175 | 175 | |
176 | 176 | |
177 | 177 | |
|
0 commit comments