Commit 4d27930
test: fix flaky test-tls-socket-close
Add error listener to ignore `ECONNRESET`. Makes test reliable while it
still segfaults (as expected) on Node.js 7.7.3. It might not be possible
to eliminate the probable race causing `ECONNRESET` without also
eliminating the required segfault-inducing part of the test. (Or maybe
it's totally possible. If you figure it out, hey cool, submit a pull
request.)
PR-URL: #13529
Fixes: #13184
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>1 parent 3da56ac commit 4d27930Copy full SHA for 4d27930
File tree
Expand file treeCollapse file tree
1 file changed
+16
-5
lines changedOpen diff view settings
Filter options
- test/parallel
Expand file treeCollapse file tree
1 file changed
+16
-5
lines changedOpen diff view settings
Collapse file
test/parallel/test-tls-socket-close.js
Copy file name to clipboardExpand all lines: test/parallel/test-tls-socket-close.js+16-5Lines changed: 16 additions & 5 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
32 | 32 | |
33 | 33 | |
34 | 34 | |
35 | | - |
36 | | - |
| 35 | + |
| 36 | + |
| 37 | + |
| 38 | + |
| 39 | + |
37 | 40 | |
38 | | - |
| 41 | + |
39 | 42 | |
40 | | - |
| 43 | + |
| 44 | + |
| 45 | + |
41 | 46 | |
42 | 47 | |
43 | 48 | |
| ||
55 | 60 | |
56 | 61 | |
57 | 62 | |
58 | | - |
| 63 | + |
| 64 | + |
| 65 | + |
| 66 | + |
| 67 | + |
| 68 | + |
| 69 | + |
0 commit comments