Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 4d173ea

Browse filesBrowse files
dmabuptMylesBorins
authored andcommitted
test: uv_tty_init returns EBADF on IBM i
When TTY initialization failed, uv_tty_init returned EBADF on IBM i PASE, rather than EINVAL PR-URL: #32338 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
1 parent 79fdc6b commit 4d173ea
Copy full SHA for 4d173ea

File tree

Expand file treeCollapse file tree

1 file changed

+5
-4
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+5
-4
lines changed
Open diff view settings
Collapse file

‎test/parallel/test-ttywrap-invalid-fd.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-ttywrap-invalid-fd.js
+5-4Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -21,13 +21,14 @@ assert.throws(
2121

2222
{
2323
const info = {
24-
code: common.isWindows ? 'EBADF' : 'EINVAL',
25-
message: common.isWindows ? 'bad file descriptor' : 'invalid argument',
26-
errno: common.isWindows ? UV_EBADF : UV_EINVAL,
24+
code: common.isWindows || common.isIBMi ? 'EBADF' : 'EINVAL',
25+
message: common.isWindows ||
26+
common.isIBMi ? 'bad file descriptor' : 'invalid argument',
27+
errno: common.isWindows || common.isIBMi ? UV_EBADF : UV_EINVAL,
2728
syscall: 'uv_tty_init'
2829
};
2930

30-
const suffix = common.isWindows ?
31+
const suffix = common.isWindows || common.isIBMi ?
3132
'EBADF (bad file descriptor)' : 'EINVAL (invalid argument)';
3233
const message = `TTY initialization failed: uv_tty_init returned ${suffix}`;
3334

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.