Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 4c59b60

Browse filesBrowse files
jdapenaruyadorno
authored andcommitted
src: add support for ETW stack walking
V8 supports native stack walking in Windows by providing JIT code information to ETW (Event Tracing for Windows). But the option to enable it is not exposed in NodeJS. Just add command line (and environment variable) support for --enable-etw-stack-walking, that maps to V8 option of the same name. Fixes: #46202 PR-URL: #46203 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
1 parent 4ae2492 commit 4c59b60
Copy full SHA for 4c59b60

File tree

Expand file treeCollapse file tree

2 files changed

+7
-0
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

2 files changed

+7
-0
lines changed
Open diff view settings
Collapse file

‎doc/api/cli.md‎

Copy file name to clipboardExpand all lines: doc/api/cli.md
+3Lines changed: 3 additions & 0 deletions
  • Display the source diff
  • Display the rich diff
Original file line numberDiff line numberDiff line change
@@ -1970,6 +1970,7 @@ V8 options that are allowed are:
19701970

19711971
* `--abort-on-uncaught-exception`
19721972
* `--disallow-code-generation-from-strings`
1973+
* `--enable-etw-stack-walking`
19731974
* `--huge-max-old-generation-size`
19741975
* `--interpreted-frames-native-stack`
19751976
* `--jitless`
@@ -1986,6 +1987,8 @@ V8 options that are allowed are:
19861987
`--perf-basic-prof-only-functions`, `--perf-basic-prof`,
19871988
`--perf-prof-unwinding-info`, and `--perf-prof` are only available on Linux.
19881989

1990+
`--enable-etw-stack-walking` is only available on Windows.
1991+
19891992
### `NODE_PATH=path[:…]`
19901993

19911994
<!-- YAML
Collapse file

‎src/node_options.cc‎

Copy file name to clipboardExpand all lines: src/node_options.cc
+4Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -752,6 +752,10 @@ PerIsolateOptionsParser::PerIsolateOptionsParser(
752752
&PerIsolateOptions::report_signal,
753753
kAllowedInEnvvar);
754754
Implies("--report-signal", "--report-on-signal");
755+
AddOption("--enable-etw-stack-walking",
756+
"provides heap data to ETW Windows native tracing",
757+
V8Option{},
758+
kAllowedInEnvvar);
755759

756760
AddOption("--experimental-top-level-await", "", NoOp{}, kAllowedInEnvvar);
757761

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.