Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 4bdef48

Browse filesBrowse files
RaisinTendanielleadams
authored andcommitted
tools: remove faulty early termination logic from update-timezone.mjs
We do not build Node.js in the workflow so https://github.com/nodejs/node/blob/f4815fcd7691364d8139b44c1295dbc46f6ee4a8/tools/update-timezone.mjs#L18 is actually the version of `tzdata` in the Node.js in the runner instead of what's in `main`. The script is pretty fast even when the versions differ and there is an update, so this optimization doesn't seem to be worth having given the problem. Signed-off-by: Darshan Sen <raisinten@gmail.com> PR-URL: #44870 Fixes: #44865 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
1 parent 19d8574 commit 4bdef48
Copy full SHA for 4bdef48

File tree

Expand file treeCollapse file tree

1 file changed

+0
-7
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+0
-7
lines changed
Open diff view settings
Collapse file

‎tools/update-timezone.mjs‎

Copy file name to clipboardExpand all lines: tools/update-timezone.mjs
-7Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@
22
// Usage: tools/update-timezone.mjs
33
import { execSync } from 'node:child_process';
44
import { renameSync, readdirSync, rmSync } from 'node:fs';
5-
import { exit } from 'node:process';
65

76
const fileNames = [
87
'zoneinfo64.res',
@@ -15,14 +14,8 @@ const availableVersions = readdirSync('icu-data/tzdata/icunew', { withFileTypes:
1514
.filter((dirent) => dirent.isDirectory())
1615
.map((dirent) => dirent.name);
1716

18-
const currentVersion = process.versions.tz;
1917
const latestVersion = availableVersions.sort().at(-1);
2018

21-
if (latestVersion === currentVersion) {
22-
console.log(`Terminating early, tz version is latest @ ${currentVersion}`);
23-
exit();
24-
}
25-
2619
execSync('bzip2 -d deps/icu-small/source/data/in/icudt*.dat.bz2');
2720
fileNames.forEach((file) => {
2821
renameSync(`icu-data/tzdata/icunew/${latestVersion}/44/le/${file}`, `deps/icu-small/source/data/in/${file}`);

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.