Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 4bc5423

Browse filesBrowse files
Trottaddaleax
authored andcommitted
doc: update 2fa information in onboarding.md
Because it is no longer possible to add someone to the nodejs GitHub organization if they do not have two-factor authentication enabled, update the text of the onboarding documentatino to reflect this. PR-URL: #18968 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: Weijia Wang <starkwang@126.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Shingo Inoue <leko.noor@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Matheus Marchini <matheus@sthima.com>
1 parent b456e31 commit 4bc5423
Copy full SHA for 4bc5423

File tree

Expand file treeCollapse file tree

1 file changed

+4
-7
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+4
-7
lines changed
Open diff view settings
Collapse file

‎doc/onboarding.md‎

Copy file name to clipboardExpand all lines: doc/onboarding.md
+4-7Lines changed: 4 additions & 7 deletions
  • Display the source diff
  • Display the rich diff
Original file line numberDiff line numberDiff line change
@@ -5,20 +5,17 @@ onboarding session.
55

66
## One week before the onboarding session
77

8-
* Confirm that the new Collaborator is using two-factor authentication on their
9-
GitHub account. Unless two-factor authentication is enabled, do not give an
10-
account elevated privileges such as the ability to land code in the main
11-
repository or to start continuous integration (CI) jobs.
8+
* If the new Collaborator is not yet a member of the nodejs GitHub organization,
9+
confirm that they are using two-factor authentication. It will not be possible
10+
to add them to the organization if they are not using two-factor
11+
authentication.
1212
* Announce the accepted nomination in a TSC meeting and in the TSC
1313
mailing list.
1414

1515
## Fifteen minutes before the onboarding session
1616

1717
* Prior to the onboarding session, add the new Collaborator to
1818
[the Collaborators team](https://github.com/orgs/nodejs/teams/collaborators).
19-
Note that this is the step that gives the account elevated privileges, so do
20-
not perform this step (or any subsequent steps) unless two-factor
21-
authentication is enabled on the new Collaborator's GitHub account.
2219

2320
## Onboarding session
2421

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.