Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 4b82aa8

Browse filesBrowse files
Maya Anilsoncodebytere
authored andcommitted
src: elevate namespaces of repeated artifacts
PR-URL: #24429 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
1 parent e7d41c0 commit 4b82aa8
Copy full SHA for 4b82aa8

File tree

Expand file treeCollapse file tree

1 file changed

+7
-6
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+7
-6
lines changed
Open diff view settings
Collapse file

‎src/node_i18n.cc‎

Copy file name to clipboardExpand all lines: src/node_i18n.cc
+7-6Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -91,6 +91,7 @@ using v8::Int32;
9191
using v8::Isolate;
9292
using v8::Local;
9393
using v8::MaybeLocal;
94+
using v8::NewStringType;
9495
using v8::Object;
9596
using v8::ObjectTemplate;
9697
using v8::String;
@@ -257,7 +258,7 @@ class ConverterObject : public BaseObject, Converter {
257258

258259
protected:
259260
ConverterObject(Environment* env,
260-
v8::Local<v8::Object> wrap,
261+
Local<Object> wrap,
261262
UConverter* converter,
262263
bool ignoreBOM,
263264
const char* sub = nullptr) :
@@ -506,7 +507,7 @@ void ICUErrorName(const FunctionCallbackInfo<Value>& args) {
506507
args.GetReturnValue().Set(
507508
String::NewFromUtf8(env->isolate(),
508509
u_errorName(status),
509-
v8::NewStringType::kNormal).ToLocalChecked());
510+
NewStringType::kNormal).ToLocalChecked());
510511
}
511512

512513
#define TYPE_ICU "icu"
@@ -552,7 +553,7 @@ void GetVersion(const FunctionCallbackInfo<Value>& args) {
552553
TYPE_ICU ","
553554
TYPE_UNICODE ","
554555
TYPE_CLDR ","
555-
TYPE_TZ, v8::NewStringType::kNormal).ToLocalChecked());
556+
TYPE_TZ, NewStringType::kNormal).ToLocalChecked());
556557
} else {
557558
CHECK_GE(args.Length(), 1);
558559
CHECK(args[0]->IsString());
@@ -565,7 +566,7 @@ void GetVersion(const FunctionCallbackInfo<Value>& args) {
565566
// Success.
566567
args.GetReturnValue().Set(
567568
String::NewFromUtf8(env->isolate(),
568-
versionString, v8::NewStringType::kNormal).ToLocalChecked());
569+
versionString, NewStringType::kNormal).ToLocalChecked());
569570
}
570571
}
571572
}
@@ -722,7 +723,7 @@ static void ToUnicode(const FunctionCallbackInfo<Value>& args) {
722723
args.GetReturnValue().Set(
723724
String::NewFromUtf8(env->isolate(),
724725
*buf,
725-
v8::NewStringType::kNormal,
726+
NewStringType::kNormal,
726727
len).ToLocalChecked());
727728
}
728729

@@ -745,7 +746,7 @@ static void ToASCII(const FunctionCallbackInfo<Value>& args) {
745746
args.GetReturnValue().Set(
746747
String::NewFromUtf8(env->isolate(),
747748
*buf,
748-
v8::NewStringType::kNormal,
749+
NewStringType::kNormal,
749750
len).ToLocalChecked());
750751
}
751752

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.