Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 4af4a80

Browse filesBrowse files
Trottaddaleax
authored andcommitted
doc: remove problematic auto-linking of curl man pages
The only instance of curl man page linking is in repl.md and it is explicit. The magic autolinking in html.js creates a superfluous empty link. Remove it. Before, two adjacent links generated, with the first one having no text: ```html <a href="https://curl.haxx.se/docs/manpage.html"></a> <a href="https://curl.haxx.se/docs/manpage.html"><code>curl(1)</code></a> ``` After, just one link: ```html <a href="https://curl.haxx.se/docs/manpage.html"><code>curl(1)</code></a> ``` PR-URL: #35174 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ben Coe <bencoe@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
1 parent 55ed2d2 commit 4af4a80
Copy full SHA for 4af4a80

File tree

Expand file treeCollapse file tree

2 files changed

+2
-6
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

2 files changed

+2
-6
lines changed
Open diff view settings
Collapse file

‎doc/api/repl.md‎

Copy file name to clipboardExpand all lines: doc/api/repl.md
+2-2Lines changed: 2 additions & 2 deletions
  • Display the source diff
  • Display the rich diff
Original file line numberDiff line numberDiff line change
@@ -732,7 +732,7 @@ For an example of running a "full-featured" (`terminal`) REPL over
732732
a `net.Server` and `net.Socket` instance, see:
733733
<https://gist.github.com/TooTallNate/2209310>.
734734

735-
For an example of running a REPL instance over [curl(1)][], see:
735+
For an example of running a REPL instance over [`curl(1)`][], see:
736736
<https://gist.github.com/TooTallNate/2053342>.
737737

738738
[ZSH]: https://en.wikipedia.org/wiki/Z_shell
@@ -748,5 +748,5 @@ For an example of running a REPL instance over [curl(1)][], see:
748748
[`util.inspect()`]: util.html#util_util_inspect_object_options
749749
[`reverse-i-search`]: #repl_reverse_i_search
750750
[TTY keybindings]: readline.html#readline_tty_keybindings
751-
[curl(1)]: https://curl.haxx.se/docs/manpage.html
751+
[`curl(1)`]: https://curl.haxx.se/docs/manpage.html
752752
[stream]: stream.html
Collapse file

‎tools/doc/html.js‎

Copy file name to clipboardExpand all lines: tools/doc/html.js
-4Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -126,7 +126,6 @@ function preprocessText({ nodeVersion }) {
126126

127127
// Syscalls which appear in the docs, but which only exist in BSD / macOS.
128128
const BSD_ONLY_SYSCALLS = new Set(['lchmod']);
129-
const HAXX_ONLY_SYSCALLS = new Set(['curl']);
130129
const MAN_PAGE = /(^|\s)([a-z.]+)\((\d)([a-z]?)\)/gm;
131130

132131
// Handle references to man pages, eg "open(2)" or "lchmod(2)".
@@ -143,9 +142,6 @@ function linkManPages(text) {
143142
return `${beginning}<a href="https://www.freebsd.org/cgi/man.cgi` +
144143
`?query=${name}&sektion=${number}">${displayAs}</a>`;
145144
}
146-
if (HAXX_ONLY_SYSCALLS.has(name)) {
147-
return `${beginning}<a href="https://${name}.haxx.se/docs/manpage.html">${displayAs}</a>`;
148-
}
149145

150146
return `${beginning}<a href="http://man7.org/linux/man-pages/man${number}` +
151147
`/${name}.${number}${optionalCharacter}.html">${displayAs}</a>`;

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.