Commit 4acea14
process: do not directly schedule _tickCallback in _fatalException
When a process encounters a _fatalException that is caught, it should
schedule execution of nextTicks but not in an arbitrary place of the
next Immediates queue. Instead, add a no-op function to the queue
that will ensure processImmediate runs, which will then ensure
that nextTicks are processed at the end.
Backport-PR-URL: #19006
PR-URL: #17841
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>1 parent d348496 commit 4acea14Copy full SHA for 4acea14
File tree
Expand file treeCollapse file tree
2 files changed
+44
-25
lines changedOpen diff view settings
Filter options
- lib/internal
- test/parallel
Expand file treeCollapse file tree
2 files changed
+44
-25
lines changedOpen diff view settings
Collapse file
lib/internal/bootstrap_node.js
Copy file name to clipboardExpand all lines: lib/internal/bootstrap_node.js+20-25Lines changed: 20 additions & 25 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
409 | 409 | |
410 | 410 | |
411 | 411 | |
| 412 | + |
| 413 | + |
412 | 414 | |
413 | 415 | |
414 | 416 | |
| ||
419 | 421 | |
420 | 422 | |
421 | 423 | |
422 | | - |
423 | | - |
424 | 424 | |
425 | 425 | |
426 | 426 | |
427 | 427 | |
428 | 428 | |
429 | 429 | |
430 | | - |
431 | | - |
432 | | - |
433 | | - |
434 | | - |
435 | | - |
436 | | - |
437 | | - |
438 | | - |
| 430 | + |
| 431 | + |
| 432 | + |
439 | 433 | |
440 | 434 | |
441 | 435 | |
| ||
444 | 438 | |
445 | 439 | |
446 | 440 | |
| 441 | + |
| 442 | + |
447 | 443 | |
| 444 | + |
| 445 | + |
| 446 | + |
| 447 | + |
| 448 | + |
| 449 | + |
| 450 | + |
| 451 | + |
| 452 | + |
| 453 | + |
| 454 | + |
448 | 455 | |
449 | | - |
450 | | - |
451 | | - |
452 | | - |
453 | | - |
454 | | - |
455 | | - |
456 | | - |
457 | | - |
458 | | - |
459 | | - |
460 | | - |
461 | | - |
| 456 | + |
462 | 457 | |
463 | 458 | |
464 | | - |
| 459 | + |
465 | 460 | |
466 | 461 | |
467 | 462 | |
|
Collapse file
test/parallel/test-process-fatal-exception-tick.js
Copy file name to clipboard+24Lines changed: 24 additions & 0 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
| 1 | + |
| 2 | + |
| 3 | + |
| 4 | + |
| 5 | + |
| 6 | + |
| 7 | + |
| 8 | + |
| 9 | + |
| 10 | + |
| 11 | + |
| 12 | + |
| 13 | + |
| 14 | + |
| 15 | + |
| 16 | + |
| 17 | + |
| 18 | + |
| 19 | + |
| 20 | + |
| 21 | + |
| 22 | + |
| 23 | + |
| 24 | + |
0 commit comments