Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 4ace010

Browse filesBrowse files
committed
repl: remove deprecated bufferedCommand property
This property is deprecated since Node.js v9.0.0 and to improve maintainability of the REPL it is now removed. Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de> PR-URL: #33286 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
1 parent 3752430 commit 4ace010
Copy full SHA for 4ace010

File tree

Expand file treeCollapse file tree

2 files changed

+4
-10
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

2 files changed

+4
-10
lines changed
Open diff view settings
Collapse file

‎doc/api/deprecations.md‎

Copy file name to clipboardExpand all lines: doc/api/deprecations.md
+4-1Lines changed: 4 additions & 1 deletion
  • Display the source diff
  • Display the rich diff
Original file line numberDiff line numberDiff line change
@@ -1547,12 +1547,15 @@ code, no replacement API is provided.
15471547
### DEP0074: `REPLServer.bufferedCommand`
15481548
<!-- YAML
15491549
changes:
1550+
- version: REPLACEME
1551+
pr-url: https://github.com/nodejs/node/pull/33286
1552+
description: End-of-Life.
15501553
- version: v9.0.0
15511554
pr-url: https://github.com/nodejs/node/pull/13687
15521555
description: Runtime deprecation.
15531556
-->
15541557

1555-
Type: Runtime
1558+
Type: End-of-Life
15561559

15571560
The `REPLServer.bufferedCommand` property was deprecated in favor of
15581561
[`REPLServer.clearBufferedCommand()`][].
Collapse file

‎lib/repl.js‎

Copy file name to clipboardExpand all lines: lib/repl.js
-9Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -626,15 +626,6 @@ function REPLServer(prompt,
626626
});
627627

628628
self.clearBufferedCommand();
629-
ObjectDefineProperty(this, 'bufferedCommand', {
630-
get: deprecate(() => self[kBufferedCommandSymbol],
631-
'REPLServer.bufferedCommand is deprecated',
632-
'DEP0074'),
633-
set: deprecate((val) => self[kBufferedCommandSymbol] = val,
634-
'REPLServer.bufferedCommand is deprecated',
635-
'DEP0074'),
636-
enumerable: true
637-
});
638629

639630
function completer(text, cb) {
640631
complete.call(self, text, self.editorMode ?

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.