Commit 4a747f6
Revert "src: remove trace_sync_io_ from env"
This reverts commit 7fa5f54.
The reverted commit breaks the logic behind --trace-sync-io, it should
be enabled only at a certain point in time, while that commit enables
it from the very start, causing warnings be printed for all sync io
instead of sync io after the first tick of the event loop as documented.
Fixes: #28913
Refs: #22726
Refs: https://nodejs.org/api/cli.html#cli_trace_sync_io
PR-URL: #28926
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>1 parent bdd442f commit 4a747f6Copy full SHA for 4a747f6
File tree
Expand file treeCollapse file tree
4 files changed
+5
-2
lines changedOpen diff view settings
Filter options
- src
Expand file treeCollapse file tree
4 files changed
+5
-2
lines changedOpen diff view settings
Collapse file
+1-1Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
465 | 465 | |
466 | 466 | |
467 | 467 | |
468 | | - |
| 468 | + |
469 | 469 | |
470 | 470 | |
471 | 471 | |
|
Collapse file
+1-1Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
567 | 567 | |
568 | 568 | |
569 | 569 | |
570 | | - |
| 570 | + |
571 | 571 | |
572 | 572 | |
573 | 573 | |
|
Collapse file
+1Lines changed: 1 addition & 0 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
1250 | 1250 | |
1251 | 1251 | |
1252 | 1252 | |
| 1253 | + |
1253 | 1254 | |
1254 | 1255 | |
1255 | 1256 | |
|
Collapse file
+2Lines changed: 2 additions & 0 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
111 | 111 | |
112 | 112 | |
113 | 113 | |
| 114 | + |
| 115 | + |
114 | 116 | |
115 | 117 | |
116 | 118 | |
|
0 commit comments