Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 4a3300e

Browse filesBrowse files
RReverserevanlucas
authored andcommitted
buffer: fix creating from zero-length ArrayBuffer
Fixes regression where creating a new Buffer from an empty ArrayBuffer would fail. Ref: 85ab4a5 PR-URL: #7176 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: Ron Korving <ron@ronkorving.nl>
1 parent 2a023bf commit 4a3300e
Copy full SHA for 4a3300e

File tree

Expand file treeCollapse file tree

2 files changed

+6
-1
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

2 files changed

+6
-1
lines changed
Open diff view settings
Collapse file

‎lib/buffer.js‎

Copy file name to clipboardExpand all lines: lib/buffer.js
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -218,7 +218,7 @@ function fromArrayBuffer(obj, byteOffset, length) {
218218

219219
const maxLength = obj.byteLength - byteOffset;
220220

221-
if (maxLength <= 0)
221+
if (maxLength < 0)
222222
throw new RangeError("'offset' is out of bounds");
223223

224224
if (length === undefined) {
Collapse file

‎test/parallel/test-buffer-alloc.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-buffer-alloc.js
+5Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1458,3 +1458,8 @@ const ubuf = Buffer.allocUnsafeSlow(10);
14581458
assert(ubuf);
14591459
assert(ubuf.buffer);
14601460
assert.equal(ubuf.buffer.byteLength, 10);
1461+
1462+
// Regression test
1463+
assert.doesNotThrow(() => {
1464+
Buffer.from(new ArrayBuffer());
1465+
});

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.