Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 49ee30b

Browse filesBrowse files
refackMylesBorins
authored andcommitted
test: more robust check for location of node.exe
look for the actual produced `exe` not just the directory PR-URL: #12120 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Nikolai Vavilov <vvnicholas@gmail.com>
1 parent a93eaa4 commit 49ee30b
Copy full SHA for 49ee30b

File tree

Expand file treeCollapse file tree

1 file changed

+6
-8
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+6
-8
lines changed
Open diff view settings
Collapse file

‎tools/test.py‎

Copy file name to clipboardExpand all lines: tools/test.py
+6-8Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -890,14 +890,12 @@ def GetVm(self, arch, mode):
890890
# http://code.google.com/p/gyp/issues/detail?id=40
891891
# It will put the builds into Release/node.exe or Debug/node.exe
892892
if utils.IsWindows():
893-
out_dir = os.path.join(dirname(__file__), "..", "out")
894-
if not exists(out_dir):
895-
if mode == 'debug':
896-
name = os.path.abspath('Debug/node.exe')
897-
else:
898-
name = os.path.abspath('Release/node.exe')
899-
else:
900-
name = os.path.abspath(name + '.exe')
893+
if not exists(name + '.exe'):
894+
name = name.replace('out/', '')
895+
name = os.path.abspath(name + '.exe')
896+
897+
if not exists(name):
898+
raise ValueError('Could not find executable. Should be ' + name)
901899

902900
return name
903901

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.